[PM-39778] Subtitle alignment bank account license passport#1222
[PM-39778] Subtitle alignment bank account license passport#1222jengstrom-bw wants to merge 10 commits into
Conversation
🔍 SDK Breaking Change DetectionSDK Version:
Breaking change detection uses the build of the SDK from this branch, including any incompatibities pre-existing on or merged into this branch. Check the workflow logs to confirm. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1222 +/- ##
==========================================
+ Coverage 85.19% 85.23% +0.04%
==========================================
Files 477 477
Lines 66126 66345 +219
==========================================
+ Hits 56333 56548 +215
- Misses 9793 9797 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jengstrom-bw
added
the
ai-review-vnext
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed the vault subtitle alignment changes for bank account, license, and passport ciphers. The new Code Review DetailsNo blocking findings. The one breaking change — |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
…nt-license-passport
|
…nt-license-passport
…nt-license-passport
…nt-license-passport
…nt-license-passport
1 participant
🎟️ Tracking
Jira
📔 Objective
Align the subtitle for bank account, license, and passport to the TS implementation.
🚨 Breaking Changes
The CipherListViewType enum variant for bank accounts changed from a unit variant to a tuple variant carrying data:
// Before (main)
BankAccount,
// After (this branch)
BankAccount(BankAccountListView),
crates/bitwarden-vault/src/cipher/cipher.rs:488
What BankAccountListView is
A new minimal view type added in bank_account.rs holding only the fields needed to render list rows:
pub struct BankAccountListView {
pub account_number: Option,
pub account_type: Option,
}